Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value and is_required not appropriately interacting #2725

Closed
schrockn opened this issue Jul 15, 2020 · 0 comments
Closed

Default value and is_required not appropriately interacting #2725

schrockn opened this issue Jul 15, 2020 · 0 comments
Assignees

Comments

@schrockn
Copy link
Member

If a scalar field gets a default value, it should not be considered required since in the absence

for example:

    @solid(config_schema={'default_to_one': Field(int, default_value=1)})
    def return_default_to_one(context):
        return context.solid_config['default_to_one']

    # This currently throws. It should not require configuration as the
    # the default value should make it *not* required.
    execute_solid(return_default_to_one)

This should work and the solid should return 1. It currently does not. I believes that it requires configuration.

schrockn pushed a commit that referenced this issue Jul 16, 2020
Summary: I'm fairly scandalized by this bug and am shocked it is in the system. We should fix this asap.

Test Plan: BK

Reviewers: sandyryza, alangenfeld, max

Reviewed By: sandyryza

Differential Revision: https://dagster.phacility.com/D3894
@gibsondan gibsondan self-assigned this Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants