Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PermissiveDict type to permit config with unknown parameters #1024

Merged
merged 3 commits into from
Mar 26, 2019

Conversation

natekupp
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Mar 25, 2019

Pull Request Test Coverage Report for Build 101740

  • 20 of 20 (100.0%) changed or added relevant lines in 4 files are covered.
  • 137 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.2%) to 84.845%

Files with Coverage Reduction New Missed Lines %
python_modules/dagster/dagster/core/execution_context.py 3 97.66%
python_modules/dagster/dagster/core/user_context.py 8 74.19%
python_modules/dagit/dagit/pipeline_execution_manager.py 10 91.2%
python_modules/airline-demo/airline_demo/solids.py 10 90.74%
python_modules/dagster/dagster/core/object_store.py 13 88.59%
python_modules/dagster/dagster/core/types/marshal.py 16 47.37%
python_modules/dagit/dagit/schema/model.py 20 83.24%
python_modules/dagster/dagster/core/execution.py 22 90.45%
python_modules/dagit/dagit/pipeline_run_storage.py 35 75.34%
Totals Coverage Status
Change from base Build 101162: -0.2%
Covered Lines: 7698
Relevant Lines: 9073

💛 - Coveralls

Copy link
Member

@schrockn schrockn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per discussion on slack use "Permissive" verbiage to describe what is happening here and then add test cases.

This will also have to be exposed to the graphql interface, and then the config editor will have to be changed.

@natekupp natekupp changed the title Add UntypedDict type to permit config with unknown parameters Add PermissiveDict type to permit config with unknown parameters Mar 25, 2019
@schrockn schrockn self-requested a review March 25, 2019 22:21
Copy link
Member

@schrockn schrockn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool. can you make sure to add a task to support this in the config editor?

@natekupp natekupp merged commit 8f787c2 into master Mar 26, 2019
@natekupp natekupp deleted the nate/add_untyped_dict branch March 26, 2019 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants