Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor airline demo to use S3DownloadManager #1030

Merged
merged 2 commits into from
Mar 25, 2019
Merged

Refactor airline demo to use S3DownloadManager #1030

merged 2 commits into from
Mar 25, 2019

Conversation

schrockn
Copy link
Member

config quite a bit more minimal

@schrockn schrockn requested a review from mgasner March 25, 2019 21:33
mgasner
mgasner approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@mgasner mgasner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing. We could even push this off onto the types.

@schrockn
cp
880807e 
add s3 download manager resource

config fix

cp

make target_folder required

cp
@schrockn schrockn force-pushed the schrockn/refactor-airline-demo branch from c39fcac to 880807e Compare March 25, 2019 22:26
@coveralls
Copy link

coveralls commented Mar 25, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 102358

  • 24 of 25 (96.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 85.025%
Changes Missing Coverage Covered Lines Changed/Added Lines %
python_modules/airline-demo/airline_demo/resources.py 22 23 95.65%
Files with Coverage Reduction New Missed Lines %
python_modules/airline-demo/airline_demo/utils.py 4 76.19%
Totals Coverage Status
Change from base Build 102202: -0.02%
Covered Lines: 7733
Relevant Lines: 9095
💛 - Coveralls

@schrockn schrockn merged commit 77e375f into master Mar 25, 2019
@mgasner mgasner deleted the schrockn/refactor-airline-demo branch March 26, 2019 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgasner mgasner mgasner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@schrockn @coveralls @mgasner