Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up pre commit hook for black #1048

Merged
merged 9 commits into from Mar 27, 2019

Conversation

Projects
None yet
3 participants
@mgasner
Copy link
Collaborator

commented Mar 26, 2019

Resolves #599

@mgasner mgasner self-assigned this Mar 26, 2019

@mgasner mgasner requested a review from schrockn Mar 26, 2019

@coveralls

This comment has been minimized.

Copy link

commented Mar 26, 2019

Pull Request Test Coverage Report for Build 105569

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.092%

Totals Coverage Status
Change from base Build 105070: 0.0%
Covered Lines: 7797
Relevant Lines: 9163

💛 - Coveralls
@schrockn
Copy link
Member

left a comment

not checkin doc snapshots?

mgasner added some commits Mar 27, 2019

Revert "Update snapshot"
This reverts commit cbaeba0.
@mgasner

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 27, 2019

Fixed the --exclude -- this is remarkably underdocumented.

@mgasner mgasner merged commit 69a6d26 into master Mar 27, 2019

41 checks passed

WIP Ready for review
Details
ci/circleci: airline-demo-py27 Your tests passed on CircleCI!
Details
ci/circleci: airline-demo-py35 Your tests passed on CircleCI!
Details
ci/circleci: airline-demo-py36 Your tests passed on CircleCI!
Details
ci/circleci: airline-demo-py37 Your tests passed on CircleCI!
Details
ci/circleci: coverage Your tests passed on CircleCI!
Details
ci/circleci: dagit-py27 Your tests passed on CircleCI!
Details
ci/circleci: dagit-py35 Your tests passed on CircleCI!
Details
ci/circleci: dagit-py36 Your tests passed on CircleCI!
Details
ci/circleci: dagit-py37 Your tests passed on CircleCI!
Details
ci/circleci: dagit-webapp Your tests passed on CircleCI!
Details
ci/circleci: dagma-py27 Your tests passed on CircleCI!
Details
ci/circleci: dagma-py35 Your tests passed on CircleCI!
Details
ci/circleci: dagma-py36 Your tests passed on CircleCI!
Details
ci/circleci: dagma-py37 Your tests passed on CircleCI!
Details
ci/circleci: dagster-airflow-py27 Your tests passed on CircleCI!
Details
ci/circleci: dagster-airflow-py35 Your tests passed on CircleCI!
Details
ci/circleci: dagster-airflow-py36 Your tests passed on CircleCI!
Details
ci/circleci: dagster-ge-py27 Your tests passed on CircleCI!
Details
ci/circleci: dagster-ge-py35 Your tests passed on CircleCI!
Details
ci/circleci: dagster-ge-py36 Your tests passed on CircleCI!
Details
ci/circleci: dagster-ge-py37 Your tests passed on CircleCI!
Details
ci/circleci: dagster-pandas-py27 Your tests passed on CircleCI!
Details
ci/circleci: dagster-pandas-py35 Your tests passed on CircleCI!
Details
ci/circleci: dagster-pandas-py36 Your tests passed on CircleCI!
Details
ci/circleci: dagster-pandas-py37 Your tests passed on CircleCI!
Details
ci/circleci: dagster-py27 Your tests passed on CircleCI!
Details
ci/circleci: dagster-py35 Your tests passed on CircleCI!
Details
ci/circleci: dagster-py36 Your tests passed on CircleCI!
Details
ci/circleci: dagster-py37 Your tests passed on CircleCI!
Details
ci/circleci: dagster-sqlalchemy-py27 Your tests passed on CircleCI!
Details
ci/circleci: dagster-sqlalchemy-py35 Your tests passed on CircleCI!
Details
ci/circleci: dagster-sqlalchemy-py36 Your tests passed on CircleCI!
Details
ci/circleci: dagster-sqlalchemy-py37 Your tests passed on CircleCI!
Details
ci/circleci: dagstermill-py27 Your tests passed on CircleCI!
Details
ci/circleci: dagstermill-py35 Your tests passed on CircleCI!
Details
ci/circleci: dagstermill-py36 Your tests passed on CircleCI!
Details
ci/circleci: dagstermill-py37 Your tests passed on CircleCI!
Details
ci/circleci: format Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
dagster-io.dagster Build #20190327.15 succeeded
Details

@mgasner mgasner deleted the pre-commit-hooks branch Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.