Capture db timeout errors for tag key queries #12596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
prha
force-pushed
the
prha/suppress_timeout_errors
branch
from
06e5bab
to
e8e1175
Compare
alangenfeld
approved these changes
Mar 1, 2023
| @@ -329,21 +344,21 @@ def test_get_runs_over_graphql(self, graphql_context): | |||
| assert len(runs) == 2 | |||
|
|
|||
| all_tag_keys_result = execute_dagster_graphql(read_context, ALL_TAG_KEYS_QUERY) | |||
| tag_keys = set(all_tag_keys_result.data["runTagKeys"]) | |||
| tag_keys = set(all_tag_keys_result.data["runTagKeysOrError"]["keys"]) | |||
There was a problem hiding this comment.
test the PythonError path - maybe use mock to force throwing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
We're hitting some timeout 500s for some orgs/deployments. We can capture and suppress these, since the degraded experience in the product is just that there's not autocomplete for tags in the runs filter input (which was the behavior before).
How I Tested These Changes
BK