[embedded-elt] Add Sling asset decorator #19057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
PedramNavid
force-pushed
the
pdrm/sling-decorator
branch
from
892a71f
to
11cf816
Compare
PedramNavid
force-pushed
the
pdrm/sling-decorator
branch
3 times, most recently
from
b51d236
to
b9b9664
Compare
rexledesma
reviewed
Jan 16, 2024
There was a problem hiding this comment.
Exciting to see these patterns come to dagster-embedded-elt!
Would be nice to check in some examples in experimental/ as we're iterating on the API design of this.
Seeing the examples (e.g. #14301) of how this accomplishes existing + new use cases with the integration will give me more confidence.
python_modules/libraries/dagster-embedded-elt/dagster_embedded_elt/sling/asset_decorator.py
Outdated
Show resolved
Hide resolved
python_modules/libraries/dagster-embedded-elt/dagster_embedded_elt/sling/asset_decorator.py
Outdated
Show resolved
Hide resolved
python_modules/libraries/dagster-embedded-elt/dagster_embedded_elt/sling/asset_decorator.py
Outdated
Show resolved
Hide resolved
python_modules/libraries/dagster-embedded-elt/dagster_embedded_elt/sling/resources.py
Outdated
Show resolved
Hide resolved
python_modules/libraries/dagster-embedded-elt/dagster_embedded_elt/sling/asset_decorator.py
Outdated
Show resolved
Hide resolved
sryza
reviewed
Jan 16, 2024
python_modules/libraries/dagster-embedded-elt/dagster_embedded_elt/sling/asset_decorator.py
Outdated
Show resolved
Hide resolved
sryza
reviewed
Jan 16, 2024
python_modules/libraries/dagster-embedded-elt/dagster_embedded_elt/sling/asset_decorator.py
Outdated
Show resolved
Hide resolved
sryza
reviewed
Jan 16, 2024
python_modules/libraries/dagster-embedded-elt/dagster_embedded_elt/sling/asset_decorator.py
Outdated
Show resolved
Hide resolved
PedramNavid
force-pushed
the
pdrm/sling-decorator
branch
from
1b0cdb9
to
db9c7b2
Compare
PedramNavid
force-pushed
the
pdrm/sling-decorator
branch
from
db9c7b2
to
f5dbb8f
Compare
PedramNavid
changed the title
PedramNavid
force-pushed
the
pdrm/sling-decorator
branch
from
f5dbb8f
to
659dc16
Compare
PedramNavid
force-pushed
the
pdrm/sling-decorator
branch
3 times, most recently
from
403eb85
to
c024a7d
Compare
This was referenced Feb 15, 2024
Closed
PedramNavid
force-pushed
the
pdrm/sling-decorator
branch
from
c024a7d
to
48a6f73
Compare
3 tasks
PedramNavid
force-pushed
the
pdrm/sling-decorator
branch
3 times, most recently
from
d6fa2f6
to
b2f558a
Compare
PedramNavid
force-pushed
the
pdrm/sling-decorator
branch
2 times, most recently
from
ca3a854
to
4ca2e84
Compare
PedramNavid
force-pushed
the
pdrm/sling-decorator
branch
3 times, most recently
from
4fe8137
to
e15d58b
Compare
PedramNavid
force-pushed
the
pdrm/elt-revert-18270
branch
from
3ca6683
to
9e82251
Compare
PedramNavid
force-pushed
the
pdrm/sling-decorator
branch
from
860f58c
to
bf0c4dd
Compare
…onfig paths; added CSV to SQLite replication test and configs.
- Yield sanitized stdout with timings from `replicate` method in SlingResource. - Capture raw logs in `_stdout` list for later streaming. - Include elapsed time metadata in `MaterializeResult` when yielding sync results. - Add Docker-related files for testing Postgres to DuckDB replication using Sling.
…s for disabled asset configs.
PedramNavid
force-pushed
the
pdrm/sling-decorator
branch
from
bf0c4dd
to
c5313b7
Compare
cmpadden
approved these changes
Feb 23, 2024
PedramNavid
added a commit
that referenced
this pull request
Mar 28, 2024
## Summary & Motivation Adds a Sling Asset Decorator to dagster-embedded-elt, This new decorator uses Sling's `replication` config which allows specifying multiple source/targets within a single configuration file. 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This adds a Sling Asset Decorator to dagster-embedded-elt, while deprecating the
build_sling_assetbuilder.This new decorator uses Sling's
replicationconfig which allows specifying multiple source/targets within a single configuration file.A follow-up PR will add docs and examples.