Upgrade configuration for Ruff v0.2.0 #19544
Conversation
| @@ -26,7 +28,7 @@ extend-ignore = [ | |||
| "TCH", | |||
| ] | |||
|
|
|||
| [tool.ruff.isort] | |||
| [tool.ruff.lint.isort] | |||
There was a problem hiding this comment.
Linter settings are in general now under tool.ruff.lint, with settings that are shared between Ruff's linter and formatter at the top-level (tool.ruff). So this is all just moving settings around between those sections as appropriate.
| fd.write( | ||
| "result_backend = '{result_backend}'\n".format( | ||
| result_backend=str(validated_config["backend"]) | ||
| ) | ||
| ) | ||
| if "config_source" in validated_config and validated_config["config_source"]: | ||
| if validated_config.get("config_source"): |
There was a problem hiding this comment.
These are violations for an existing rule that Dagster has enabled, but whose scope was extended in a later release. So this just avoids violations showing up after you upgrade.
|
nice, thanks! |
|
Thanks @charliermarsh-- it's easier to do this according to some existing internal norms for linter update PRs, so I'm going to close in favor of this PR, but this was helpful in getting it right! |
|
@smackesey - No prob at all, goal was just to make the upgrade easier for you all so as long as it was somewhat helpful I'm happy. |
This PR upgrades Dagster's configuration to avoid deprecation warnings that will appear after upgrading to Ruff's upcoming v0.2.0 release. (All these changes work with v0.1.7 as-is.)