[embedded-elt] Update Sling docs and examples #20028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PedramNavid
force-pushed
the
pdrm/sling-deprecate
branch
from
5cd3761
to
4f108d8
Compare
PedramNavid
force-pushed
the
pdrm/sling-docs-v2
branch
3 times, most recently
from
2fa56e2
to
e6858f8
Compare
PedramNavid
force-pushed
the
pdrm/sling-docs-v2
branch
from
e6858f8
to
1192a12
Compare
cmpadden
reviewed
Feb 27, 2024
cmpadden
approved these changes
Feb 27, 2024
PedramNavid
force-pushed
the
pdrm/sling-deprecate
branch
2 times, most recently
from
a2a19d4
to
071fb51
Compare
PedramNavid
force-pushed
the
pdrm/sling-docs-v2
branch
from
4b969e6
to
5b4f3c8
Compare
|
Deploy preview for dagster-university ready! ✅ Preview Built with commit 4b969e6. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 4b969e6. |
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 4b969e6. |
PedramNavid
force-pushed
the
pdrm/sling-docs-v2
branch
2 times, most recently
from
7ba4952
to
0d09a7b
Compare
Refactor documentation for the 'embedded-elt' and 'sling' APIs for improved readability and clarity. Add code snippets and API usage examples, correct hyperlink references, and adjust API definitions to match their actual usage within the python modules. Also, deprecate 'build_sling_asset' function and use '@public' decorators to indicate public methods. docs: update documentation for Dagster Embedded ELT Updated the documentation for the Sling implementation of the Embedded ELT package to reflect changes to the way connections and replication configurations are setup. Also simplified examples and provided more detailed instructions for setting up resources, assets, and replication configurations. Improved inline code examples by adhering to code standards and removed the use of os to get environment variables, instead using `EnvVar`. docs: update embedded ELT and api documentation - Corrected the description of the embedded ELT feature in _apidocs.mdx - Added details on configuration, credential management and resource creation for the Sling integration in embedded-elt.mdx docs: update embedded ELT and api documentation - Corrected the description of the embedded ELT feature in _apidocs.mdx - Added details on configuration, credential management and resource creation for the Sling integration in embedded-elt.mdx Revert
PedramNavid
force-pushed
the
pdrm/sling-docs-v2
branch
from
c70f475
to
2b622be
Compare
Subdivided examples into 'Database to Database' and 'File to Database'.
shalabhc
pushed a commit
that referenced
this pull request
Feb 29, 2024
## Summary & Motivation Updates Sling docs to use new API, deprecating the old one.
PedramNavid
added a commit
that referenced
this pull request
Mar 28, 2024
## Summary & Motivation Updates Sling docs to use new API, deprecating the old one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Updates Sling docs to use new API, deprecating the old one.
I moved the Relevant API section to the bottom as well, for an easier flow.
How I Tested These Changes