fix(dbt): read dbt +meta from +config when present
#20296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @rexledesma and the rest of your teammates on |
rexledesma
force-pushed
the
rl/read-dbt-config-inheritance-sources
branch
2 times, most recently
from
89b8db1
to
8d141c1
Compare
rexledesma
force-pushed
the
rl/read-dbt-config-inheritance-sources
branch
from
8d141c1
to
ff00b7c
Compare
rexledesma
changed the base branch from
flexible_upstream_asset_association
to
master
|
Deploy preview for dagster-university ready! ✅ Preview Built with commit ff00b7c. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit ff00b7c. |
OwenKephart
approved these changes
Mar 6, 2024
python_modules/libraries/dagster-dbt/dagster_dbt/asset_utils.py
Outdated
Show resolved
Hide resolved
rexledesma
force-pushed
the
rl/read-dbt-config-inheritance-sources
branch
from
ff00b7c
to
1d756c0
Compare
PedramNavid
pushed a commit
that referenced
this pull request
Mar 28, 2024
## Summary & Motivation From https://docs.getdbt.com/reference/resource-configs/meta: > Depending on the resource you're configuring, meta may be available within the config property, and/or as a top-level key. (For backwards compatibility, meta is often (but not always) supported as a top-level key, though without the capabilities of config inheritance.) This affects sources, as `+meta` config inheritance is applied in the top level `+config` field, rather than in the top level `+meta` field. This change reads from `+config` when present to read `+meta`. Otherwise, we fall back to reading from the top level `+meta` field. ## How I Tested These Changes pytest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
From https://docs.getdbt.com/reference/resource-configs/meta:
This affects sources, as
+metaconfig inheritance is applied in the top level+configfield, rather than in the top level+metafield.This change reads from
+configwhen present to read+meta. Otherwise, we fall back to reading from the top level+metafield.How I Tested These Changes
pytest