[ui] Asset overview - Sidebar tweaks #20376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes FE-208, FE-209
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 531897b. |
hellendag
approved these changes
Mar 11, 2024
| @@ -444,22 +464,29 @@ const AssetNodeOverviewContainer = ({ | |||
| </Box> | |||
| ); | |||
|
|
|||
| const isEmptyChildren = (children: React.ReactNode) => | |||
| !children || (children instanceof Array && children.length === 0); | |||
There was a problem hiding this comment.
This feels a bit fragile -- like if some other empty-ish render output (empty fragment, <span />, etc.) were supplied as children, it would fail this check. Not a huge deal though.
There was a problem hiding this comment.
Yeah I agree -- if it moves out of this file we may need something more sophisticated :-/
PedramNavid
pushed a commit
that referenced
this pull request
Mar 28, 2024
## Summary & Motivation Fixes FE-208, Fixes FE-209 ## How I Tested These Changes Just visual tweaks here --------- Co-authored-by: bengotow <bgotow@elementl.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Fixes FE-208, Fixes FE-209
How I Tested These Changes
Just visual tweaks here