Asset tags in the UI #20389
Merged
Asset tags in the UI #20389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 03e3cab. |
hellendag
reviewed
Mar 11, 2024
sryza
force-pushed
the
asset-tags
branch
2 times, most recently
from
2dfe80e
to
a6b561c
Compare
sryza
force-pushed
the
graphql-asset-tags
branch
from
4dd3b34
to
ccf1bbc
Compare
schrockn
reviewed
Mar 11, 2024
sryza
force-pushed
the
graphql-asset-tags
branch
from
ccf1bbc
to
b0b0550
Compare
|
@hellendag - added a screenshot to the PR description. I haven't handled individual tags that exceed the width, and was hoping to pass that off to someone on the frontend team as a followup. |
hellendag
approved these changes
Mar 11, 2024
sryza
force-pushed
the
graphql-asset-tags
branch
from
b0b0550
to
29cb275
Compare
sryza
force-pushed
the
graphql-asset-tags
branch
2 times, most recently
from
1e281c8
to
67c0e8c
Compare
branch-name: graphql-asset-tags
sryza
force-pushed
the
graphql-asset-tags
branch
from
67c0e8c
to
03e3cab
Compare
PedramNavid
pushed a commit
that referenced
this pull request
Mar 28, 2024
## Summary & Motivation This PR passes tags up through graphql to the UI and displays them on the asset overview page. It doesn't yet support the no-value tags introduced in this PR: #20388. Stacks on top of #20351. <img width="1167" alt="image" src="https://github.com/dagster-io/dagster/assets/654855/97bcb447-06e6-4cd1-a0f2-4fdfffdd1d0d"> ## How I Tested These Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This PR passes tags up through graphql to the UI and displays them on the asset overview page. It doesn't yet support the no-value tags introduced in this PR: #20388.
Stacks on top of #20351.
How I Tested These Changes