-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #21695 terminate runs #21775
Issue #21695 terminate runs #21775
Conversation
…ent, allowing to terminate multiple runs
Hi @baumann-t - thanks for sending this out. It looks like this needs a 'make ruff' and |
Hello @gibsondan! I've run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baumann-t I realized one thing from looking at your query again - I don't think the TERMINATE_RUNS_JOB_MUTATION mutation is actually using the termationPolicy argument? you could either add it to the graphql query (being sure to re-run the snapshot command again) or remove it from the python
020a719
to
35917b9
Compare
@gibsondan good catch thank you!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Summary
This PR adds an extra method to the DagsterGraphQL python client to enable the possibility to terminate multiple runs at the same time.
This PR is related to the following issue: #21695
How I Tested These Changes
The PR contains a suit of unit tests similar to the other methods defined on the client, testing multiple edge cases for error handling.