[dagster-dbt][fix] use standalone duckdb dbfile for row count test #21852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @benpankow and the rest of your teammates on |
rexledesma
approved these changes
May 14, 2024
| it, rather than using the default one-file-per-worker approach. | ||
| """ | ||
| jaffle_shop_duckdb_db_file_name = "cool_jaffle_shop" | ||
| jaffle_shop_duckdb_dbfile_path = f"target/{jaffle_shop_duckdb_db_file_name}.duckdb" |
There was a problem hiding this comment.
Should probably parameterize this by the test name to guarantee isolations between tests
There was a problem hiding this comment.
had this initially but changed it to test something and forgot to change it back 😅 , thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix for flaky dagster-dbt test which uses a standalone duckdb file for the row count test, to control for duckdb holding the file lock.
Replaces #21763
Test Plan
bk