store backfill logs using instigation logger #22003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @jamiedemaria and the rest of your teammates on |
jamiedemaria
force-pushed
the
jamie/store-backfill-logs
branch
from
8378bb2
to
f7d4185
Compare
jamiedemaria
commented
May 23, 2024
| if os.getenv("STORE_BACKFILL_LOGS", None): | ||
| evaluation_time = pendulum.now("UTC") | ||
| log_key = ["backfill", backfill_id, evaluation_time.strftime("%Y%m%d_%H%M%S")] | ||
| with InstigationLogger( |
There was a problem hiding this comment.
the InstigationLogger always uses the dagster logger, whereas the backfill daemon uses the backfill-daemon-logger
likely need to make the name of the logger a parameter to instigation logger or something
|
@alangenfeld @prha marking this PR and some related ones as ready for review to get them into review queues. Similar deal as with the other prototype PRs, these aren't actually ready for merging, I just want to start getting feedback on this direction and figure out what problems exist that we need to address |
This was referenced May 28, 2024
|
Same, I think this looks pretty clean. |
jamiedemaria
changed the title
alangenfeld
approved these changes
May 29, 2024
jamiedemaria
force-pushed
the
jamie/store-backfill-logs
branch
4 times, most recently
from
96a0354
to
25e5fec
Compare
jamiedemaria
force-pushed
the
jamie/store-backfill-logs
branch
from
25e5fec
to
b5a0491
Compare
benpankow
pushed a commit
that referenced
this pull request
Jun 5, 2024
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
stores backfill logs using the InstigationLogger. gated on an instance method that we can override to control roll out.
related internal pr https://github.com/dagster-io/internal/pull/9879
How I Tested These Changes