Freshness sensor fix instance method + in-progress checks handling #22013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dpeng817
force-pushed
the
dpeng817/freshness_sensor_fix
branch
from
a287102
to
2758648
Compare
dpeng817
force-pushed
the
dpeng817/freshness_sensor_fix
branch
from
2758648
to
dfd952f
Compare
johannkm
approved these changes
May 22, 2024
| @@ -155,7 +122,70 @@ def ordered_iterator_freshness_checks_starting_with_key( | |||
| # Offset based on the left off asset check key, but then iterate back through the beginning afterwards | |||
| if left_off_asset_check_key: | |||
| left_off_idx = asset_check_keys_sorted.index(left_off_asset_check_key) | |||
| yield from asset_check_keys_sorted[left_off_idx:] | |||
| yield from asset_check_keys_sorted[:left_off_idx] | |||
| yield from asset_check_keys_sorted[left_off_idx + 1 :] | |||
There was a problem hiding this comment.
realized that this method of indexing was actually inclusive; meaning we would start iterating at the item we evaluated the previous run of the sensor, rather than the item after the last one we evaluated. this fixes (and I added a test for the ordering behavior)
OwenKephart
pushed a commit
that referenced
this pull request
May 22, 2024
Uses the newly added get_asset_check_summary_record to implement the freshness check sensor. Adds some more tests for previously under-handled cases; having an asset which is currently in planned state, and ensuring that cursoring works properly.
nikomancy
pushed a commit
that referenced
this pull request
May 22, 2024
Uses the newly added get_asset_check_summary_record to implement the freshness check sensor. Adds some more tests for previously under-handled cases; having an asset which is currently in planned state, and ensuring that cursoring works properly.
dpeng817
changed the title
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jun 18, 2024
Uses the newly added get_asset_check_summary_record to implement the freshness check sensor. Adds some more tests for previously under-handled cases; having an asset which is currently in planned state, and ensuring that cursoring works properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the newly added get_asset_check_summary_record to implement the freshness check sensor.
Adds some more tests for previously under-handled cases; having an asset which is currently in planned state, and ensuring that cursoring works properly.