Fix error in k8s configuration docs #22092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibsondan
force-pushed
the
fixprecedencedocs
branch
from
f99ea8f
to
d5249da
Compare
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-2khid6091-elementl.vercel.app Direct link to changed pages: |
alangenfeld
approved these changes
May 24, 2024
Summary: We were incorrectly saying that merge_behavior is a child of pod_spec_config, but it is a sibling. Update the docs to reflect reality.
gibsondan
force-pushed
the
fixprecedencedocs
branch
from
d5249da
to
c619b36
Compare
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jun 18, 2024
Summary: We were incorrectly saying that merge_behavior is a child of pod_spec_config, but it is a sibling. Update the docs to reflect reality. ## Summary & Motivation ## How I Tested These Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We were incorrectly saying that merge_behavior is a child of pod_spec_config, but it is a sibling. Update the docs to reflect reality.
Summary & Motivation
How I Tested These Changes