Refetch indexeddb cached query immediately #22517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit cbc7a83. |
salazarm
commented
Jun 12, 2024
| }, [key, version, getCachedData]); | ||
|
|
||
| React.useEffect(() => { | ||
| fetch(true); |
There was a problem hiding this comment.
The true argument here makes the fetch call skip the cache.
clairelin135
approved these changes
Jun 13, 2024
salazarm
added a commit
that referenced
this pull request
Jun 13, 2024
## Summary & Motivation Recent changes to this file regressed the immediate fetch from the server in favor of only fetching from cache. This PR adds back the fetching from the server behavior to update the cache. ## How I Tested These Changes App proxy, see requests fire in the network panel: <img width="682" alt="Screenshot 2024-06-12 at 7 51 09 PM" src="https://github.com/dagster-io/dagster/assets/2286579/f1301542-e542-4cd8-96cd-262776671e65">
cmpadden
pushed a commit
that referenced
this pull request
Jun 13, 2024
## Summary & Motivation Recent changes to this file regressed the immediate fetch from the server in favor of only fetching from cache. This PR adds back the fetching from the server behavior to update the cache. ## How I Tested These Changes App proxy, see requests fire in the network panel: <img width="682" alt="Screenshot 2024-06-12 at 7 51 09 PM" src="https://github.com/dagster-io/dagster/assets/2286579/f1301542-e542-4cd8-96cd-262776671e65">
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jun 18, 2024
## Summary & Motivation Recent changes to this file regressed the immediate fetch from the server in favor of only fetching from cache. This PR adds back the fetching from the server behavior to update the cache. ## How I Tested These Changes App proxy, see requests fire in the network panel: <img width="682" alt="Screenshot 2024-06-12 at 7 51 09 PM" src="https://github.com/dagster-io/dagster/assets/2286579/f1301542-e542-4cd8-96cd-262776671e65">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Recent changes to this file regressed the immediate fetch from the server in favor of only fetching from cache. This PR adds back the fetching from the server behavior to update the cache.
How I Tested These Changes
App proxy, see requests fire in the network panel: