[Workspace] Stop showing spinner when code locations are no longer loading #22532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 5b080f4. |
alangenfeld
approved these changes
Jun 13, 2024
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jun 18, 2024
…ading (dagster-io#22532) ## Summary & Motivation Now that useCodeLocationsStatus isn't in charge of the actual refetch it needs to manually check if any code location is not loading in order to stop showing the spinner ## How I Tested These Changes Update a code location and make sure the spinner next to the deployment tab stops showing when its done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Now that useCodeLocationsStatus isn't in charge of the actual refetch it needs to manually check if any code location is not loading in order to stop showing the spinner
How I Tested These Changes
Update a code location and make sure the spinner next to the deployment tab stops showing when its done