making dagster grpc requirements more friendly with other package deps #3085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jmo-qap
commented
Oct 12, 2020
•
jmo-qap
commented
- Fixes dagster grpcio pinning is incompatible with pulumi grpcio pinning #3080 (verified locally by installing both packages)
- No regression to protobuf version requirement #2660 locally
- Tests pass locally
- generated code changes should not have an impact. They are in the "experimental" section of gRPC, are backward compatible, or generated comments.
|
Thanks a ton for digging in here and following up on your well crafted issue with a well crafted PR. This looks good to me, I will double check with some other folks on the team and likely merge this assuming it clears buildkite (you can ignore the current azure failures). |
mgasner
reviewed
Oct 13, 2020
| @@ -68,8 +68,8 @@ def get_version(): | |||
| # core (not explicitly expressed atm) | |||
| "alembic>=1.2.1", | |||
| "croniter>=0.3.34", | |||
| "grpcio==1.30.0", # pinned so that code generated by grpc will work | |||
| "protobuf==3.12.4", # pinned so that code generated by grpc will work | |||
| "grpcio>=1.32.0", # ensure version we require is >= that with which we generated the grpc code (set in dev-requirements) | |||
There was a problem hiding this comment.
Is it asking too much to have a test which checks this against dev-requirements?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.