Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EventMetadata parsing #4615

Merged
merged 1 commit into from Aug 24, 2021
Merged

Fix EventMetadata parsing #4615

merged 1 commit into from Aug 24, 2021

Conversation

ymrzkrrs
Copy link
Contributor

Parse EventMetadata.asset and EventMetadata.piepline_run correctly when they are passed in the metadata dict.
Fixes #4613

Summary

Test Plan

Checklist

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Parse `EventMetadata.asset` and `EventMetadata.piepline_run` correctly when they are passed in the `metadata` dict.
Fixes dagster-io#4613
@vercel
Copy link

vercel bot commented Aug 24, 2021

@ymrzkrrs is attempting to deploy a commit to the Elementl Team on Vercel.

A member of the Team first needs to authorize it.

@drewsonne drewsonne mentioned this pull request Aug 24, 2021
2 tasks
@drewsonne
Copy link
Contributor

@vercel
Copy link

vercel bot commented Aug 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/elementl/dagster/6k9HU8GNuDy7oWF31fQfHG3Fv7uS
✅ Preview: https://dagster-git-fork-ymrzkrrs-patch-1-elementl.vercel.app

Copy link
Contributor

@sryza sryza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build failures are unrelated. This looks good to me. Thanks for fixing!

@sryza sryza merged commit 4b6f2c2 into dagster-io:master Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EventMetadata.asset and EventMetadata.piepline_run are not parsed correctly
4 participants