Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dagit] When relaunching a run, preserve log / step filters on the page #6124

Merged
merged 1 commit into from Jan 7, 2022
Merged

[dagit] When relaunching a run, preserve log / step filters on the page #6124

merged 1 commit into from Jan 7, 2022

Conversation

bengotow
Copy link
Collaborator

@bengotow bengotow commented Jan 6, 2022

Resolves #2839

Summary

  • When you re-execute a run from the run details page, any selections you have in the filter bar or log query bar are preserved when you move to the new run details page. Rather than make this code aware of the specific querystring key/values that are used elsewhere on the page, I just apply the entire querystring to the new page. This seemed less likely to break in the future as we iterate on the page.

image

Test Plan

Checklist

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@vercel
Copy link

vercel bot commented Jan 6, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

dagster – ./docs/next

🔍 Inspect: https://vercel.com/elementl/dagster/DadfE8nrAyzDqZUu4wqR9SkVYcvc
✅ Preview: Canceled

[Deployment for 700b6e4 canceled]

dagit-storybook – ./js_modules/dagit/packages/core

🔍 Inspect: https://vercel.com/elementl/dagit-storybook/9YLZFokDzeuky23vsJkyDkae14AJ
✅ Preview: https://dagit-storybook-git-abg-preserve-log-filter-state-elementl.vercel.app

@bengotow bengotow force-pushed the abg/preserve-log-filter-state branch from 79b9863 to 700b6e4 Compare January 6, 2022 20:38
@vercel vercel bot temporarily deployed to Preview – dagster January 6, 2022 20:38 Inactive
hellendag
hellendag approved these changes Jan 7, 2022
View reviewed changes
js_modules/dagit/packages/core/src/runs/RunUtils.tsx
@@ -40,7 +40,7 @@ export function handleLaunchResult(
basePath: string,
pipelineName: string,
result: void | {data?: LaunchPipelineExecution | LaunchPipelineReexecution | null},
openInTab?: boolean,
options: {openInTab?: boolean; querystring?: string},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely better!

@bengotow bengotow merged commit fd7b015 into master Jan 7, 2022
@bengotow bengotow deleted the abg/preserve-log-filter-state branch January 7, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellendag hellendag hellendag approved these changes

@prha prha Awaiting requested review from prha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Launching re-execution doesn't preserve log filter state
2 participants
@bengotow @hellendag