[dagit] Fix runtime errors in useViewport #6246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). dagit-storybook – ./js_modules/dagit/packages/ui🔍 Inspect: https://vercel.com/elementl/dagit-storybook/7ttu6jJSYRNdFnUQUDmnhv254Wms [Deployment for ed91d55 canceled] dagster – ./docs/next🔍 Inspect: https://vercel.com/elementl/dagster/EErZF2FwzwowqEysZhKpExo94geR [Deployment for ed91d55 canceled] |
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
|
Also tidying up some deps based on yarn spew. |
hellendag
force-pushed
the
dish-use-viewport
branch
from
6de77cf
to
87e8e30
Compare
hellendag
force-pushed
the
dish-use-viewport
branch
from
87e8e30
to
e80f592
Compare
bengotow
approved these changes
Jan 20, 2022
hellendag
force-pushed
the
dish-use-viewport
branch
from
e80f592
to
0800207
Compare
hellendag
force-pushed
the
dish-use-viewport
branch
from
0800207
to
3652277
Compare
hellendag
force-pushed
the
dish-use-viewport
branch
from
3652277
to
ed91d55
Compare
hellendag
commented
Jan 20, 2022
| const suggestions = React.useMemo(() => buildSuggestions(queryString), [ | ||
| buildSuggestions, | ||
| queryString, | ||
| ]); |
There was a problem hiding this comment.
This keeps getting caught by lint runs. I believe this should iron it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is an occasional Cloud runtime error within
useViewport, where the ref is not actually an element. The ref is currently being set toany, so there are no TS safeguards in place to prevent this.Fix this up by tracking a typed object.
Test Plan
View Gantt chart and parition matrix. Verify that they behave correctly, with no errors.