Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dagster-io/ui] Fix AnchorButton stories #6248

Merged
merged 1 commit into from Jan 19, 2022
Merged

Conversation

hellendag
Copy link
Member

Summary

The stories for AnchorButton are broken in Storybook because we aren't including a MemoryRouter at the root in @dagster-io/ui. Fix this.

Test Plan

yarn storybook, verify that these stories work.

@vercel
Copy link

vercel bot commented Jan 18, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

dagster – ./docs/next

🔍 Inspect: https://vercel.com/elementl/dagster/C2g9tpmeMt1eNAFuJwnrsk295EVT
✅ Preview: Canceled

dagit-storybook – ./js_modules/dagit/packages/ui

🔍 Inspect: https://vercel.com/elementl/dagit-storybook/4pN6j2s8zcqLM5yj49A1WFEqCyoh
✅ Preview: Canceled

@vercel vercel bot temporarily deployed to Preview – dagster January 18, 2022 23:12 Inactive
@hellendag
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@vercel vercel bot temporarily deployed to Preview – dagit-storybook January 18, 2022 23:12 Inactive
Copy link
Collaborator

@bengotow bengotow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hellendag hellendag merged commit 3231f73 into master Jan 19, 2022
@hellendag hellendag deleted the dish-fix-storybook branch January 19, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants