Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] dagster-mssql #6952

Closed
wants to merge 1 commit into from
Closed

[WIP] dagster-mssql #6952

wants to merge 1 commit into from

Conversation

nico525
Copy link

@nico525 nico525 commented Mar 5, 2022

Summary

This work in progress PR adds basic mssql backend functionality for run, event and log storage. It relies on pyodbc and mssql odbc driver provided by microsoft. The decision is based on pymssql's future being unclear with only few maintainers. See here for details.
Most of this is copied over from postgres and mysql libraries, but adjusted to some minor database specifics of mssql.

Test Plan

There is no Test Plan, yet! I am happy to receive any further support on this by other maintainers.

Checklist

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@vercel
Copy link

vercel bot commented Mar 5, 2022

@nico525 is attempting to deploy a commit to the Elementl Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Mar 5, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

dagit-storybook – ./js_modules/dagit/packages/ui

🔍 Inspect: https://vercel.com/elementl/dagit-storybook/21RYRxaAKGS8oThbJrRYG4yZvfLv
✅ Preview: Canceled

@vercel vercel bot temporarily deployed to Preview – dagit-storybook March 5, 2022 08:52 Inactive
@vsiddu
Copy link

vsiddu commented Mar 22, 2022

Hi nico525, How to get the changed files and deply on my local setup. i want to try them. Thanks

@sryza sryza self-requested a review April 12, 2022 20:54
@sryza
Copy link
Contributor

sryza commented Apr 12, 2022

@nico525 thanks for the contribution and sorry that it took us a long time to get to it. I think this is the kind of contribution that we would prefer to live outside of the core Dagster repo at this time, as the core team of Dagster maintainers doesn't have the mssql expertise that would be required to maintain this going forward. If you wanted to post a repository with this integration, we would love to link it from our docs.

@sryza
Copy link
Contributor

sryza commented Apr 25, 2022

I'm going to close this PR for bookkeeping purposes. Feel free to reopen if you'd like to argue that this should go into the main dagster repo.

@sryza sryza closed this Apr 25, 2022
@nico525
Copy link
Author

nico525 commented Apr 25, 2022

Sorry for the radio silence. Somehow missed the comments on this.
Unfortunately, I will not be able to host a package on my own without any further support and will be closing the fork due to this pretty soon. If anyone is up to maintaining this, please feel free to contact me.

@nico525
Copy link
Author

nico525 commented Aug 7, 2022

I am now using dagster_mssql in an UAT environment and will probably maintain it on an ongoing basis (although not that regularly as you release versions...) if we decide to use it in an production environment
The package is far from perfect, but I just performed the 1.0.1 upgrade 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants