Type annotations for IOManager #8308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
smackesey
force-pushed
the
sean/io-manager-types
branch
2 times, most recently
from
6a6595d
to
b8d3ad8
Compare
sryza
approved these changes
Jun 10, 2022
| """User-defined method that loads an input to an op. | ||
|
|
||
| Args: | ||
| context (InputContext): The input context, which describes the input that's being loaded | ||
| context ("InputContext"): The input context, which describes the input that's being loaded |
There was a problem hiding this comment.
I think this might have gotten quotes as part of a find/replace
smackesey
force-pushed
the
sean/io-manager-types
branch
from
b8d3ad8
to
57f6d5f
Compare
smackesey
force-pushed
the
sean/io-manager-types
branch
from
bd60c90
to
653a40a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Type annotations, plus one runtime logic change: confirm that an output context exists when calling
get_input_asset_{key,partitions}.How I Tested These Changes
Existing tests