Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for dataframe annotations #8538

Merged
merged 1 commit into from Jun 23, 2022
Merged

Add tests for dataframe annotations #8538

merged 1 commit into from Jun 23, 2022

Conversation

dpeng817
Copy link
Contributor

Don't think this was directly under test

@vercel
Copy link

vercel bot commented Jun 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
dagit-storybook ⬜️ Ignored (Inspect) Jun 21, 2022 at 11:16PM (UTC)
dagster ⬜️ Ignored (Inspect) Jun 21, 2022 at 11:16PM (UTC)

@dpeng817 dpeng817 requested review from smackesey and sryza June 21, 2022 23:16
sryza
sryza reviewed Jun 21, 2022
View reviewed changes
Copy link
Contributor

@sryza sryza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are dataframes special in some way as a type?

@dpeng817
Copy link
Contributor Author

Are dataframes special in some way as a type?

In order to use them as type annotations before, it was necessary to use make_python_type_usable_as_dagster_type. That limitation has since been removed, but I don't think there's any tests making sure that inference works properly.

sryza
sryza approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@sryza sryza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok doesn't hurt - in general I don't think that we need to test that every type works with annotations

@dpeng817
Copy link
Contributor Author

Generally agreed. Probably overkill, but dataframes seem important enough.

@dpeng817 dpeng817 merged commit 2f9fa26 into master Jun 23, 2022
@dpeng817 dpeng817 deleted the dpeng817/dagster_pandas_type_inference_tests branch June 23, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sryza sryza sryza approved these changes

@smackesey smackesey Awaiting requested review from smackesey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dpeng817 @sryza