New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark dagster.core private #8981
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
This was referenced Jul 21, 2022
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
smackesey
force-pushed
the
sean/primitive-mapping
branch
from
July 21, 2022 14:57
4b7dd4b
to
15d6a9e
Compare
smackesey
force-pushed
the
sean/rename-core
branch
from
July 21, 2022 14:57
491de97
to
d2e54c5
Compare
smackesey
force-pushed
the
sean/primitive-mapping
branch
from
July 21, 2022 16:15
15d6a9e
to
d3dea73
Compare
smackesey
force-pushed
the
sean/rename-core
branch
from
July 21, 2022 16:15
d2e54c5
to
56659f6
Compare
Merged
smackesey
force-pushed
the
sean/primitive-mapping
branch
from
July 21, 2022 21:17
d3dea73
to
c8e046a
Compare
smackesey
force-pushed
the
sean/rename-core
branch
2 times, most recently
from
July 21, 2022 21:53
25cde29
to
da149a6
Compare
smackesey
force-pushed
the
sean/primitive-mapping
branch
from
July 21, 2022 21:58
c8e046a
to
916f5ea
Compare
smackesey
force-pushed
the
sean/rename-core
branch
from
July 21, 2022 21:58
da149a6
to
ee20453
Compare
smackesey
force-pushed
the
sean/primitive-mapping
branch
from
July 21, 2022 22:21
916f5ea
to
a900f71
Compare
smackesey
force-pushed
the
sean/rename-core
branch
from
July 21, 2022 22:21
ee20453
to
9638e07
Compare
smackesey
force-pushed
the
sean/primitive-mapping
branch
from
July 22, 2022 00:05
a900f71
to
4d5e8e0
Compare
smackesey
force-pushed
the
sean/rename-core
branch
from
July 22, 2022 00:05
9638e07
to
963fe00
Compare
smackesey
force-pushed
the
sean/primitive-mapping
branch
from
July 22, 2022 00:23
4d5e8e0
to
364436e
Compare
smackesey
force-pushed
the
sean/rename-core
branch
from
July 22, 2022 00:23
963fe00
to
3428b06
Compare
smackesey
force-pushed
the
sean/primitive-mapping
branch
from
July 22, 2022 23:10
0036e95
to
bad315d
Compare
smackesey
force-pushed
the
sean/rename-core
branch
from
July 22, 2022 23:10
0092b18
to
dedaecc
Compare
smackesey
force-pushed
the
sean/primitive-mapping
branch
from
July 22, 2022 23:57
bad315d
to
b8e2e60
Compare
smackesey
force-pushed
the
sean/rename-core
branch
from
July 22, 2022 23:57
dedaecc
to
f4f6789
Compare
smackesey
force-pushed
the
sean/primitive-mapping
branch
from
July 23, 2022 00:36
b8e2e60
to
0c88717
Compare
smackesey
force-pushed
the
sean/rename-core
branch
from
July 23, 2022 00:36
f4f6789
to
ae97187
Compare
smackesey
force-pushed
the
sean/primitive-mapping
branch
from
July 23, 2022 01:44
0c88717
to
fce90c5
Compare
smackesey
force-pushed
the
sean/rename-core
branch
from
July 23, 2022 01:44
ae97187
to
eca5aa1
Compare
smackesey
force-pushed
the
sean/primitive-mapping
branch
from
July 23, 2022 01:53
fce90c5
to
1192230
Compare
smackesey
force-pushed
the
sean/rename-core
branch
from
July 23, 2022 01:53
eca5aa1
to
c062ddf
Compare
Merged
smackesey
force-pushed
the
sean/rename-core
branch
from
July 23, 2022 11:28
6cc370c
to
57be684
Compare
smackesey
force-pushed
the
sean/rename-core
branch
from
July 23, 2022 11:30
57be684
to
ac5b828
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Marks dagster.core private. Final step of incremental adoption of privacy for all submodules. Adds sys.meta_path mappings so that imports of e.g. dagster.core are mapped to dagster._core.
Changes were done by:
Using Pylance module rename refactor to perform automated module rename
Doing associated manual renames in the docs
Also includes some logic around
ConfigurableClass
:dagster.X
->dagter._X
in theConfigurableClassData
constructor.ConfigurableClassData
that mapsdagster._X
todagster.X
The thinking behind this was to (a) find the points where all old
dagter.core
references pass through and map the module name to the new name; (b) convert to the old name when serializing in case we are communicating with an older Dagster process.Requires a sister PR in internal: https://github.com/dagster-io/internal/pull/2749
How I Tested These Changes
BK.