Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark dagster.core private #8981

Merged
merged 8 commits into from Jul 23, 2022
Merged

Mark dagster.core private #8981

merged 8 commits into from Jul 23, 2022

Conversation

smackesey
Copy link
Collaborator

@smackesey smackesey commented Jul 21, 2022

Summary & Motivation

Marks dagster.core private. Final step of incremental adoption of privacy for all submodules. Adds sys.meta_path mappings so that imports of e.g. dagster.core are mapped to dagster._core.

Changes were done by:

Using Pylance module rename refactor to perform automated module rename
Doing associated manual renames in the docs

Also includes some logic around ConfigurableClass:

  • map dagster.X -> dagter._X in the ConfigurableClassData constructor.
  • add a custom serializer to ConfigurableClassData that maps dagster._X to dagster.X

The thinking behind this was to (a) find the points where all old dagter.core references pass through and map the module name to the new name; (b) convert to the old name when serializing in case we are communicating with an older Dagster process.

Requires a sister PR in internal: https://github.com/dagster-io/internal/pull/2749

How I Tested These Changes

BK.

@vercel
Copy link

vercel bot commented Jul 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Updated
dagit-storybook ⬜️ Ignored (Inspect) Jul 23, 2022 at 11:30AM (UTC)
dagster ⬜️ Ignored (Inspect) Jul 23, 2022 at 11:30AM (UTC)
dagster-oss-cloud-consolidated ⬜️ Ignored (Inspect) Jul 23, 2022 at 11:30AM (UTC)

@smackesey smackesey mentioned this pull request Jul 21, 2022
@smackesey smackesey force-pushed the sean/rename-core branch 2 times, most recently from 25cde29 to da149a6 Compare July 21, 2022 21:53
@smackesey smackesey marked this pull request as ready for review July 21, 2022 22:27
Base automatically changed from sean/primitive-mapping to master July 23, 2022 02:33
@smackesey smackesey mentioned this pull request Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants