-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1/n] Move subscription to web worker #9795
Closed
salazarm
wants to merge
16
commits into
master
from
marco/brr-289-run-page-performance-w-large-jobs-1
Closed
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
df7adad
1/n
salazarm 7a41a23
undo makefile change
salazarm 11bd65c
Merge branch 'master' of github.com:dagster-io/dagster into marco/brr…
salazarm 96170af
uncomment
salazarm e90181e
remove try/catch
salazarm ab0100a
chunking
salazarm 5908745
single source of truth for fragments
salazarm 1541de4
feedback
salazarm 62640cf
another fragment
salazarm 603eba3
TABLE_SCHEMA_FRAGMENT
salazarm 0760389
unused import
salazarm 82c3538
another type
salazarm 4a83ddf
regenerate graphql
salazarm 194d9f2
Merge branch 'master' of github.com:dagster-io/dagster into marco/brr…
salazarm 88b6418
move out more fragments to trim bundle
salazarm 704767a
add back url flag
salazarm File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 62 additions & 0 deletions
62
js_modules/dagit/packages/core/src/app/MetadataEntryFragment.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
import {gql} from '@apollo/client'; | ||
|
||
import {TABLE_SCHEMA_FRAGMENT} from './TableSchemaFragment'; | ||
|
||
export const METADATA_ENTRY_FRAGMENT = gql` | ||
fragment MetadataEntryFragment on MetadataEntry { | ||
__typename | ||
label | ||
description | ||
... on PathMetadataEntry { | ||
path | ||
} | ||
... on JsonMetadataEntry { | ||
jsonString | ||
} | ||
... on UrlMetadataEntry { | ||
url | ||
} | ||
... on TextMetadataEntry { | ||
text | ||
} | ||
... on MarkdownMetadataEntry { | ||
mdStr | ||
} | ||
... on PythonArtifactMetadataEntry { | ||
module | ||
name | ||
} | ||
... on FloatMetadataEntry { | ||
floatValue | ||
} | ||
... on IntMetadataEntry { | ||
intValue | ||
intRepr | ||
} | ||
... on BoolMetadataEntry { | ||
boolValue | ||
} | ||
... on PipelineRunMetadataEntry { | ||
runId | ||
} | ||
... on AssetMetadataEntry { | ||
assetKey { | ||
path | ||
} | ||
} | ||
... on TableMetadataEntry { | ||
table { | ||
records | ||
schema { | ||
...TableSchemaFragment | ||
} | ||
} | ||
} | ||
... on TableSchemaMetadataEntry { | ||
schema { | ||
...TableSchemaFragment | ||
} | ||
} | ||
} | ||
${TABLE_SCHEMA_FRAGMENT} | ||
`; |
13 changes: 13 additions & 0 deletions
13
js_modules/dagit/packages/core/src/app/PythonErrorFragment.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import {gql} from '@apollo/client'; | ||
|
||
export const PYTHON_ERROR_FRAGMENT = gql` | ||
fragment PythonErrorFragment on PythonError { | ||
__typename | ||
message | ||
stack | ||
cause { | ||
message | ||
stack | ||
} | ||
} | ||
`; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
js_modules/dagit/packages/core/src/app/TableSchemaFragment.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import {gql} from '@apollo/client'; | ||
|
||
export const TABLE_SCHEMA_FRAGMENT = gql` | ||
fragment TableSchemaFragment on TableSchema { | ||
__typename | ||
columns { | ||
name | ||
description | ||
type | ||
constraints { | ||
nullable | ||
unique | ||
other | ||
} | ||
} | ||
constraints { | ||
other | ||
} | ||
} | ||
`; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
2 changes: 1 addition & 1 deletion
2
js_modules/dagit/packages/core/src/asset-graph/AssetGraphJobSidebar.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
js_modules/dagit/packages/core/src/gantt/ExecutionPlanToGraphFragment.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
import {gql} from '@apollo/client'; | ||
|
||
export const EXECUTION_PLAN_TO_GRAPH_FRAGMENT = gql` | ||
fragment ExecutionPlanToGraphFragment on ExecutionPlan { | ||
steps { | ||
key | ||
kind | ||
inputs { | ||
dependsOn { | ||
key | ||
kind | ||
} | ||
} | ||
} | ||
} | ||
`; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fragment is already defined in
PythonErrorInfo
, can you reuse that?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I didn't want the initial PR to have a ton of changes so that its easier to review but I'll do what I did in the original PR where I moved the dependencies around and changed all the imports so that theres only 1 definition