Skip to content
This repository has been archived by the owner on Nov 26, 2020. It is now read-only.

Commit

Permalink
Raise a warning when discovery returns empty
Browse files Browse the repository at this point in the history
  • Loading branch information
dagwieers committed Dec 23, 2008
1 parent 97929f2 commit fc3009b
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 4 deletions.
1 change: 1 addition & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
* 0.6.9svn - ... - release 15/12/2008
- Fixed dstat_disk plugin for total calculation on 2.6.25+ kernels (Noel J. Bergman)
- Precompile regular expressions used as a disk filter (self.diskfilter)
- Raise a warning when discovery returns empty

* 0.6.9 - Locarno - release 02/12/2008
- Input text color is now gray (again)
Expand Down
20 changes: 16 additions & 4 deletions dstat
Original file line number Diff line number Diff line change
Expand Up @@ -647,6 +647,8 @@ class dstat_disk(dstat):
name = l[2]
ret.append(name)
for item in objlist: ret.append(item)
if not ret:
raise Exception, "No suitable block devices found to monitor"
return ret

def vars(self):
Expand Down Expand Up @@ -715,6 +717,8 @@ class dstat_disk24(dstat):
name = l[3]
ret.append(name)
for item in objlist: ret.append(item)
if not ret:
raise Exception, "No suitable block devices found to monitor"
return ret

def vars(self):
Expand All @@ -726,8 +730,8 @@ class dstat_disk24(dstat):
else:
varlist = []
for name in self.discover:
if not self.diskfilter.match(name):
varlist.append(name)
if self.diskfilter.match(name): continue
varlist.append(name)
# if len(varlist) > 2: varlist = varlist[0:2]
varlist.sort()
for name in varlist:
Expand Down Expand Up @@ -787,6 +791,8 @@ class dstat_disk24old(dstat):
ret.append(name)
break
for item in objlist: ret.append(item)
if not ret:
raise Exception, "No suitable block devices found to monitor"
return ret

def vars(self):
Expand All @@ -798,8 +804,8 @@ class dstat_disk24old(dstat):
else:
varlist = []
for name in self.discover:
if not self.diskfilter.match(name):
varlist.append(name)
if self.diskfilter.match(name): continue
varlist.append(name)
# if len(varlist) > 2: varlist = varlist[0:2]
varlist.sort()
for name in varlist:
Expand Down Expand Up @@ -1041,6 +1047,8 @@ class dstat_io(dstat):
name = l[2]
ret.append(name)
for item in objlist: ret.append(item)
if not ret:
raise Exception, "No suitable block devices found to monitor"
return ret

def vars(self):
Expand Down Expand Up @@ -1179,6 +1187,8 @@ class dstat_net(dstat):
ret.append(name)
ret.sort()
for item in objlist: ret.append(item)
if not ret:
raise Exception, "No suitable network interfaces found to monitor"
return ret

def vars(self):
Expand Down Expand Up @@ -1363,6 +1373,8 @@ class dstat_swap(dstat):
for name in varlist:
if name in self.discover + ['total']:
ret.append(name)
if not ret:
raise Exception, "No suitable swap devices found to monitor"
return ret

def extract(self):
Expand Down

0 comments on commit fc3009b

Please sign in to comment.