changing the app name to githubContributors (costing 2 more lines)

daha · Jul 18, 2012 · 64f3d1c · 64f3d1c
1 parent bd649c2
commit 64f3d1c
Show file tree

Hide file tree

Showing 9 changed files with 24 additions and 23 deletions.
diff --git a/README.md b/README.md
@@ -13,7 +13,7 @@ Known differenses between this port and the original app:
 * No pluralization of the word _contributor_ in the on hover title, of
   the contributors thumbs.
 * One more json query to GitHub, 4 instead of 3.
-* Fewer lines of javascript code, 91 compared to 387, excluding lines
+* Fewer lines of javascript code, 93 compared to 387, excluding lines
   with comments and empty lines!
 
 Demo

diff --git a/app/index-e2e.html b/app/index-e2e.html
@@ -1,5 +1,5 @@
 <!doctype html>
-<html lang="en" ng-app="ghContribE2E">
+<html lang="en" ng-app="githubContributorsE2E">
 
     <head>
         <meta charset="utf-8">

diff --git a/app/index.html b/app/index.html
@@ -1,5 +1,5 @@
 <!doctype html>
-<html lang="en" ng-app="ghContrib">
+<html lang="en" ng-app="githubContributors">
 
     <head>
         <meta charset="utf-8">

diff --git a/app/js/app.js b/app/js/app.js
@@ -34,7 +34,7 @@
 /*globals angular,SearchCtrl */
 
 // Declare app level module which depends on filters, and services
-angular.module('ghContrib', ['ghContrib.services']).
+angular.module('githubContributors', ['githubContributors.services']).
     config(['$routeProvider', function ($routeProvider) {
         'use strict';
         $routeProvider.when('/', {

diff --git a/app/js/services.js b/app/js/services.js
@@ -33,20 +33,22 @@
 // OF THE POSSIBILITY OF SUCH DAMAGE.
 /*globals angular */
 
-angular.module('ghContrib.services', ['ngResource'], function ($provide) {
-    'use strict';
-    $provide.factory('githubResource', function ($resource) {
-        return $resource('https://api.github.com/:query/:user/:repo/:spec', {
-            'query': 'users',
-            'user': 'angular',
-            'repo': 'repos',
-            'spec': '',
-            'callback': 'JSON_CALLBACK',
-            'per_page': 100
-        }, {
-            'get': {
-                'method': 'JSONP'
-            }
+angular.module('githubContributors.services', ['ngResource'],
+    function ($provide) {
+        'use strict';
+        $provide.factory('githubResource', function ($resource) {
+            return $resource('https://api.github.com/:query/:user/:repo/:spec',
+                {
+                    'query': 'users',
+                    'user': 'angular',
+                    'repo': 'repos',
+                    'spec': '',
+                    'callback': 'JSON_CALLBACK',
+                    'per_page': 100
+                }, {
+                    'get': {
+                        'method': 'JSONP'
+                    }
+                });
         });
     });
-});
diff --git a/scripts/create-e2e-html.sh b/scripts/create-e2e-html.sh
@@ -4,7 +4,7 @@ infile=$1
 dir=`dirname $infile`
 outfile=$dir/index-e2e.html
 
-sed -e 's/ng-app="ghContrib"/ng-app="ghContribE2E"/' \
+sed -e 's/ng-app="githubContributors"/ng-app="githubContributorsE2E"/' \
     -e '/lib\/angular\/angular.js/a \
         <script src="../test/lib/angular/angular-mocks.js"></script>
 ' -e '/js\/app.js/a \

diff --git a/test/e2e/app-e2e.js b/test/e2e/app-e2e.js
@@ -1,6 +1,6 @@
 /*globals angular,githubResponses */
 
-angular.module('ghContribE2E', ['ghContrib', 'ngMockE2E'])
+angular.module('githubContributorsE2E', ['githubContributors', 'ngMockE2E'])
     .run(function ($httpBackend) {
         'use strict';
         $httpBackend.whenGET(/^partials\/[\s]*/).passThrough();

diff --git a/test/e2e/scenarios.js b/test/e2e/scenarios.js
@@ -141,7 +141,6 @@ describe('GitHub Contributors with mocked data', function () {
                     expect(element('li:nth-child(3) .repo-forks').text())
                         .toMatch(/\bFork\b/);
                 });
-
             });
 
         describe('user bar (no name, and 1 repo and 1 follower)', function () {

diff --git a/test/unit/controllersSpec.js b/test/unit/controllersSpec.js
@@ -45,7 +45,7 @@ describe('GitHub Contributors controllers', function () {
         expect(scope[model].other).toEqual(other);
     }
 
-    beforeEach(module('ghContrib.services'));
+    beforeEach(module('githubContributors.services'));
     beforeEach(inject(
         function ($rootScope, $controller, $routeParams, $httpBackend) {
             rootScope = $rootScope;