You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Recently, I got some stacktrace and found that ShellItemImages.GetImageAsync might throw NRE.
Although the stacktrace do not show any useful information, but I think this issue might be related to the ShellItem.Parent. ShellItem.Parent might return null.
I applied what I think is a fix for the NRE -- many more null checks. On your second point about wrapping the function in Task.Run, I don't see your request. Can you show how you'd do it for those two method calls?
Describe the bug and how to reproduce
Recently, I got some stacktrace and found that
ShellItemImages.GetImageAsync
might throw NRE.Although the stacktrace do not show any useful information, but I think this issue might be related to the ShellItem.Parent. ShellItem.Parent might return null.
Vanara/Windows.Shell.Common/ShellObjects/ShellItemImages.cs
Lines 50 to 64 in f66686c
Vanara/Windows.Shell.Common/ShellObjects/ShellItem.cs
Lines 502 to 509 in f66686c
What code is involved
Expected behavior
Should not throw NullReferenceException
By the way, it would be better to call the sync function directly rather than wait for Task.Result here, you simply warp the function in Task.Run()
Vanara/Windows.Shell.Common/ShellObjects/ShellItem.cs
Line 699 in f66686c
Vanara/Windows.Shell.Common/ShellObjects/ShellItemImages.cs
Line 30 in f66686c
The text was updated successfully, but these errors were encountered: