This repository has been archived by the owner on Feb 5, 2022. It is now read-only.
fix string in tuple for python 3 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1 @@ | |||
| {} | |||
There was a problem hiding this comment.
Could you exclude this file from the commit?
There was a problem hiding this comment.
All good suggestions.
I'll work out how to do that.
This is my first pull request.
On 13 January 2016 at 06:07, Hong Minhee notifications@github.com wrote:
In .cache/v/cache/lastfailed
#11 (comment):@@ -0,0 +1 @@
+{}Could you exclude this file from commit?
—
Reply to this email directly or view it on GitHub
https://github.com/dahlia/sider/pull/11/files#r49549811.
|
Thanks for your effort! |
dahlia
added a commit
that referenced
this pull request
Jan 13, 2016
fix string in tuple for python 3
|
Thanks for your module!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got an exception when decoding a string in a tuple in Python 3.
try:
int_str_int = Tuple(Integer, String, Integer)
encoded = int_str_int.encode((123, 'abc\ndef', 456,))
decoded = int_str_int.decode(encoded)
I fixed it and added a test.