New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for parsing globecoordinate data type #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For documentation using Sphinx, could you add wikidata/docs/globecoordinate.rst file, and add wikidata/globecoordinate
to the toctree
in wikidata/docs/wikidata.rst file?
Co-authored-by: Hong Minhee (洪 民憙) <hong.minhee@gmail.com>
Co-authored-by: Hong Minhee (洪 民憙) <hong.minhee@gmail.com>
(this should be ready for another look, whenever you get a chance) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR introduces changes to support parsing globecoordinates—this is quite important for ciites / other locations in the world. See https://www.wikidata.org/wiki/Help:Data_type#Globe_coordinate for official wikidata docs
I've been using the coordinate on https://www.wikidata.org/wiki/Q520 as an example, since it uses a nonstandard globe (Mars)