Add support for parsing quantity datatype #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlia
approved these changes
Jul 30, 2020
dahlia
reviewed
Jul 30, 2020
| amount=12, | ||
| lower_bound=None, | ||
| upper_bound=None, | ||
| unit=None) |
There was a problem hiding this comment.
Didn't you miss an assert statement to compare decoded with gold?
Co-authored-by: Hong Minhee (洪 民憙) <hong.minhee@gmail.com>
|
thanks for catching that, must have messed up the merge. |
dahlia
approved these changes
Jul 30, 2020
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces changes to support parsing quantities. See https://www.wikidata.org/wiki/Help:Data_type#Quantity for official wikidata docs
I've been using the unitless quantity at https://www.wikidata.org/wiki/Q605704 for testing, as well as the unit-bearing (and uncertain) quantity at https://www.wikidata.org/wiki/Q520.