New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
supportsWeb property on Apps #273
Conversation
All in all looks good, but I don't know if it would fix the web builds. |
I will check |
The failing test is not my fault tho (I hope) |
Seems pretty good, could you also disable the app entry on the launcher if you didnt yet? I guess you can just reuse the logic for the taskbar items |
Yeah, seems to be a gh workflow problem |
Done @HrX03
Working fine |
LGTM |
Awesome! |
import 'apps_stub.dart' if (dart.library.io) 'package:files/main.dart'; | ||
// ignore: duplicate_import | ||
import 'apps_stub.dart' if (dart.library.io) 'package:terminal/main.dart'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically what I do here is to import 'apps_stub.dart', but if we're running on dart:io, import both Files and Terminal.
Description
Some apps aren't available on the web, such as the Terminal and Files Manager. This PR adds a property that enable apps to tell if they can run on the web or not. If not, they won't show up
Depends on dahliaOS/backend#5 to be landed first
Type of change
Please tick the relevant option by putting an X inside the bracket
Checklist: