Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes with Dark and Light Mode #183

Closed
larsb24 opened this issue Nov 2, 2020 · 3 comments
Closed

Themes with Dark and Light Mode #183

larsb24 opened this issue Nov 2, 2020 · 3 comments

Comments

@larsb24
Copy link
Member

larsb24 commented Nov 2, 2020

Is your feature request related to a problem? Please describe.
At the moment, Themes are still very alpha, changing themes is still kind of broken and no proper Light theme

Describe the solution you'd like
Real time changing themes with light mode

Describe alternatives you've considered
None

For which platform is this feature request?

  • Platform: [Linux, Web]

Do you have an idea of how we would add it?
Working on it

Why should we add it?
Proper customization

Additional context
None

@larsb24 larsb24 added this to To do in Pangolin Desktop Nov 2, 2020
@ikeofkc
Copy link

ikeofkc commented Feb 20, 2021

Great idea! I think in general users are happy and won't complain about needing crazy theme support if you include

  1. Dark/Light modes
  2. Customized highlight color

I think dahlia likely sidesteps users need for # 2 because it seems each app has its own color highlight which is cool. I think if the variety stays there people will dig it without complaint.

(That being said people would go nuts if they could customize the color theme per app. I don't think this is likely super feasible, but I thought I'd mention since this is in it's early stages if some mechanism for each app's color to reference a user configured set of colors that auto generates it's palette form lightening or darkening the color.)

@nmcain
Copy link
Member

nmcain commented Feb 20, 2021

Its certainly feasable, UI for it may be a little complex but it should be simple to implement.

@larsb24
Copy link
Member Author

larsb24 commented Feb 20, 2021

Its certainly feasable, UI for it may be a little complex but it should be simple to implement.

It is already implemented in the re-write.

@larsb24 larsb24 closed this as completed Oct 31, 2021
@SincerelyFaust SincerelyFaust moved this from To do to Done in Pangolin Desktop Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants