Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS/feature/11/section header #14

Merged
merged 12 commits into from
Apr 23, 2021
Merged

iOS/feature/11/section header #14

merged 12 commits into from
Apr 23, 2021

Conversation

dahun-lee-daji
Copy link
Owner

@dahun-lee-daji dahun-lee-daji commented Apr 23, 2021 •
edited
Loading

진행 사항

  • 1-3. 섹션 헤더를 누르면 섹션의 상품 갯수를 보여준다. ( CocoaPods를 설치하여 toast형태로 적용한다.)
  • 1-6. 상품 이름, 상세 설명, 상품 가격은 DB에서 받은 그대로 표시한다. (상세 설명이 길 경우, linebreak를 Truncate Tail로 처리한다.)
  • 1-7. 뱃지 색상은 enum : String case에 따라 부여한다. Dictionary key:Value에 따라 부여한다.
  • 가격 표시 기획서에 맞게 수정
  • 클린 코딩

반성 할 점

commit convention을 잘 지키지 못 함 ㅜㅜ

@dahun-lee-daji
Build: 코코아팟, Toaster 모듈 import (#11)
227384a
@dahun-lee-daji
Chore: 자동적인 파일 변경 반영
9965d04
@dahun-lee-daji
Merge branch 'Dev-iOS' into iOS/feature/11/SectionHeader
d8901d4
@dahun-lee-daji
Feature : 기본 Section Header 적용 (#11)
b4243e9
@dahun-lee-daji
feature : 토스터 기능 추가 (#11)
34149bf
@dahun-lee-daji
Merge branch 'Dev-iOS' into iOS/feature/11/SectionHeader
593666e
@dahun-lee-daji
Feature : localHost 연결을 통한 cell property 지정
989e153
@dahun-lee-daji
Feature : Toaster 기능 수정 (#11)
3b1a3f8 
중복 toaster 제거 및 section 상품 수에 맞는 메세지 출력
@dahun-lee-daji
Refactor : DiffableDataSource 생성 부분 분리
456463f 
DiffalbeProvider class를 통해서 생성
@dahun-lee-daji
Feature : 가격을 형식에 맞게 보이게 수정
f478fb9
@dahun-lee-daji
Refactor : 셀 크기 조절, 클린코드를 위한 리팩토링
5dc8a1b 
셀 크기 조절 : DishCollectionViewDelegate
리팩토링 : DiffableProvider
@dahun-lee-daji dahun-lee-daji self-assigned this Apr 23, 2021
@dahun-lee-daji dahun-lee-daji added this to In progress in iOS-SideDish-Project via automation Apr 23, 2021
@dahun-lee-daji dahun-lee-daji linked an issue Apr 23, 2021 that may be closed by this pull request
[iOS] 섹션 헤더를 누르면 섹션의 상품 갯수를 보여준다. #11
Closed
4 tasks
@dahun-lee-daji
Refactor : Toaster기능을 closer로 전달
8b9bdec 
UITapGestureRecognizer를 subClassing하여 toaster를 보여주고 있었음
이를 closer로 전달하는 방식으로 변경
@HongzCloud HongzCloud merged commit 2a10f61 into Dev-iOS Apr 23, 2021
iOS-SideDish-Project automation moved this from In progress to Done Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HongzCloud HongzCloud Awaiting requested review from HongzCloud

Assignees

@dahun-lee-daji dahun-lee-daji

Labels
feat iOS iOS label
Projects
iOS-SideDish-Project
Done
Milestone
iOS-Front-End implementation Progress
Development

Successfully merging this pull request may close these issues.

[iOS] 섹션 헤더를 누르면 섹션의 상품 갯수를 보여준다.
2 participants
@dahun-lee-daji @HongzCloud