Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): add markToTrack docs and fix isDeepChanged docs #13

Merged
merged 4 commits into from Feb 21, 2021
Merged

chore(docs): add markToTrack docs and fix isDeepChanged docs #13

merged 4 commits into from Feb 21, 2021

Conversation

YPAzevedo
Copy link
Contributor

create docs for markToTrack and small fix to isDeepChanged docs

dai-shi
dai-shi approved these changes Feb 21, 2021
View reviewed changes
Copy link
Owner

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@YPAzevedo
Copy link
Contributor Author

YPAzevedo commented Feb 21, 2021 •
edited

Thanks for the updates, seems like you fixed it already @dai-shi i totally missed the typos 😅

@YPAzevedo
Copy link
Contributor Author

Let me know if it needs any more changes 👍

@YPAzevedo
Copy link
Contributor Author

@dai-shi added one more fix to the isDeepChanged in this PR

@dai-shi dai-shi merged commit 63f438a into dai-shi:master Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dai-shi dai-shi dai-shi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@YPAzevedo @dai-shi