Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For issue-33 #34

Merged
merged 5 commits into from
Jan 24, 2020
Merged

For issue-33 #34

merged 5 commits into from
Jan 24, 2020

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Jan 15, 2020 •
edited

Trying to fix #33.

This add a spec for issue #33.
We are not 100% sure if we keep this capability forever though.
(It will be in v1, but may not be in v2.)

@dai-shi dai-shi mentioned this pull request Jan 15, 2020
Closed
@dai-shi dai-shi closed this Jan 16, 2020
@dai-shi dai-shi reopened this Jan 24, 2020
@dai-shi dai-shi marked this pull request as ready for review January 24, 2020 23:04
@dai-shi
Copy link
Owner Author

dai-shi commented Jan 24, 2020

The test passed because in v1, CM support is opt-in by useGlobalStateProvider.

@dai-shi dai-shi merged commit 1c2385c into master Jan 24, 2020
@dai-shi dai-shi deleted the issue-33 branch January 24, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getGlobalState loses sync with useGlobalState after 0.17
1 participant
@dai-shi