Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable minification on compile #112

Merged
merged 1 commit into from
Feb 27, 2024
Merged

disable minification on compile #112

merged 1 commit into from
Feb 27, 2024

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Dec 1, 2023

Copy link

codesandbox-ci bot commented Dec 1, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 98f77a9:

Sandbox Source
React Configuration
React TypeScript Configuration

@dai-shi
Copy link
Owner Author

dai-shi commented Dec 1, 2023

@VictorPrata @sfl-moneytree @orkanylmz @tunghs217
Can any one try this and see where exactly the error happens in react-native 0.72?

https://ci.codesandbox.io/status/dai-shi/use-context-selector/pr/112
☝️ Find "Local Install Instructions"

@RodSarhan
Copy link

I tried the local install and this is the error that i got

TypeError: arg[0].startsWith is not a function (it is undefined), js engine: hermes
Error: While trying to resolve module `use-context-selector` from file `MY FILE PATH`, the package `MY PATH/node_modules/use-context-selector/package.json` was successfully found. However, this package itself specifies a `main` module field that could not be resolved

i also remember seeing something related to this line

const runWithNormalPriority = runWithPriority
  ? (thunk: () => void) => runWithPriority(NormalPriority, thunk)
  : (thunk: () => void) => thunk();

but can't seem to reproduce that again

@dai-shi
Copy link
Owner Author

dai-shi commented Dec 9, 2023

Thanks. Hmm, it seems a different error from "Not Implemented".

@dai-shi dai-shi merged commit 3d896c8 into main Feb 27, 2024
3 checks passed
@dai-shi dai-shi deleted the do-not-minify branch February 27, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants