Merge pull request #9 from nakatamixi/fix/bytes-update

fix UPDATE BYTES to default values
daichirata · Apr 8, 2020 · 9b280ef · 9b280ef
2 parents 1e0a744 + a6873e8
commit 9b280ef
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/internal/hammer/ddl.go b/internal/hammer/ddl.go
@@ -57,8 +57,10 @@ func (u Update) defaultValue() string {
 		return "false"
 	case spansql.Int64, spansql.Float64:
 		return "0"
-	case spansql.String, spansql.Bytes:
+	case spansql.String:
 		return "''"
+	case spansql.Bytes:
+		return "b''"
 	case spansql.Date:
 		return "'0001-01-01'"
 	case spansql.Timestamp:

diff --git a/internal/hammer/ddl_test.go b/internal/hammer/ddl_test.go
@@ -60,6 +60,10 @@ func TestUpdate_SQL(t *testing.T) {
 			d: spansql.ColumnDef{Name: "test_column", Type: spansql.Type{Base: spansql.String}},
 			s: "UPDATE test_table SET test_column = '' WHERE test_column IS NULL",
 		},
+		{
+			d: spansql.ColumnDef{Name: "test_column", Type: spansql.Type{Base: spansql.Bytes}},
+			s: "UPDATE test_table SET test_column = b'' WHERE test_column IS NULL",
+		},
 		{
 			d: spansql.ColumnDef{Name: "test_column", Type: spansql.Type{Base: spansql.String, Array: true}},
 			s: "UPDATE test_table SET test_column = [] WHERE test_column IS NULL",