Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance max distance (zoom out in radar grid) by x100 #511

Closed
wants to merge 4 commits into from

Conversation

amir-arad
Copy link
Contributor

radar grid draws sectors of relevant size

radar grid draws sectors of relevant size
@amir-arad amir-arad changed the title allow max distance of x100 of previous GM screen max distance enhance max distance (zoom out in radar grid) by x100 Dec 30, 2017
@tdelc
Copy link
Contributor

tdelc commented Dec 30, 2017

I think this PR could be problematic for arcade sessions of EE. Players could be a little bit lost in this screen. Maybe could you add the max distance as option in the server screen ?

@amir-arad
Copy link
Contributor Author

all it does is allowing the plater / GM to zoom out more. I didn't think it creates a problem, as the player can simply zoom back in.

If it needs to be configurable at the game level, I think it should be part of the map's properties, as it has to do with the size of the map. I already feel that there's room to define the coordinates system at the map level, this can be part of it.

@daid ?

@oznogon
Copy link
Contributor

oznogon commented Dec 31, 2017

Just built this and have some feedback:

  • The zoom slider doesn't handle zoom levels less than 1.0X; clicking, tapping, or dragging the slider all the way to the left results in zoom 1.0X. This means the extra zoom is inaccessible from the slider, and therefore also inaccessible if a scrollwheel or wheel-emulating gesture is unavailable.

  • On relay with default radar ranges, labels on radar objects are clipped by the radar visibility mask starting at around zoom 0.5X and smaller. Larger radar ranges only defer this issue to lower zoom levels.

    issue2

  • On relay with default radar ranges, the lowest zoom levels (<0.3X) have such little visible information that they're effectively useless except for faster map navigation to extremely distant sectors. Would being able to center the map on a sector by entering its name in an input be more effective for that use case?

    issue1

  • "Zoom" numbers are easy to grasp in the default range, but start to lose their meaning if applied to much larger spaces. The loss of scale is compounded by the new sector folding behavior, which makes massive blocks of sectors look similar to individual sectors in scale. Reporting scale in a more concrete way tied to game mechanics, such as a scale bar in units/kilounits/megaunits instead of "zoom 0.0X", might be more useful, especially to Relay, who can't readily determine distances when zoomed out to less than 1.0X.

@amir-arad
Copy link
Contributor Author

amir-arad commented Jan 8, 2018

@oznogon

  • I've "fixed" the zoom slider, though I don't see how it improves the experience. the slider was useful for fine grained zoom, and now it's too coarse IMO. Isn't it reasonable to assume that a wheel input is available to the user, just like in the GM screen?

  • I've commented out the render mask, and It seems like an improvement: now also ships that come into rage are completely displayed when inside the fog-of-war radius. could you please tell me what's the product value of the render mask?

  • I've looked at centering the map on a sector by entering its name. I've found out that sector names don't always have printable characters, and translating sector names to position is not single-valued. IMO sector names logic rewrite #512 or some similar fix is a blocker for that kind of feature

@amir-arad amir-arad closed this Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants