rewrite joystick input #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- joystick directly change ship turn speed - turnSpeed obverrides targetRotation (~ stick overrides flight plan)
…options.ini configures joystick axis actions, similar to hotkeys.
amir-arad
force-pushed
the
configure-joystick
branch
from
f21bd4d
to
dc3d376
Compare
amir-arad
force-pushed
the
configure-joystick
branch
from
8203b88
to
6d56217
Compare
amir-arad
force-pushed
the
configure-joystick
branch
from
7d3e88a
to
4d69b51
Compare
daid
reviewed
Oct 22, 2019
daid
reviewed
Mar 12, 2020
amir-arad
force-pushed
the
configure-joystick
branch
from
4c635d2
to
c6a231d
Compare
|
Just noticed something, you where missing "return" statements in the onJoystickAxis functions, which is an warning in C/C++, but IMHO, should be an error. As this will invoke undefined behavior. Chances are it worked fine in testing, but it wasn't proper code. Missed it in my review. |
olivier-vm
added a commit
to olivier-vm/EmptyEpsilon-Clones
that referenced
this pull request
Jul 25, 2021
rewrite joystick input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR includes #655
fixes #413