Change ship signatures based on system states

[oznogon]

Ship signatures can change based on their heat, power level, and
usage.

• Systems that generate heat increase the biological band; coolant
  offsets this effect even if the system maintains heat.
• Systems that use energy increase the electrical band.
• Ships that are jumping or warping spike the gravity band.

This allows Science to predict when a ship is going to warp/jump,
and in stealth missions can give away the positions of ships that
run hot.

CPU ships do not manage heat/energy but still exhibit jump/warp
spikes.

Example of a jump spike before and after:

Progress toward #14

[tdelc]

I like this PR, bit do you test it with old computers ? I have huge lags with my old PCs for the science station and I am afraid it could be worse with your feature. Le mar. 14 janv. 2020 à 13:28, oznogon <notifications@github.com> a écrit :

…

Ship signatures can change based on their heat, power level, and usage. - Systems that generate heat increase the biological band; coolant offsets this effect even if the system maintains heat. - Systems that use energy increase the electrical band. - Ships that are jumping or warping spike the gravity band. This allows Science to predict when a ship is going to warp/jump, and in stealth missions can give away the positions of ships that run hot. CPU ships do not manage heat/energy but still exhibit jump/warp spikes. Example of a jump spike before and after: [image: jumping] <https://user-images.githubusercontent.com/19192104/72344532-4f2ba780-3686-11ea-8dd0-1ecf073d6f95.png> [image: jumping2] <https://user-images.githubusercontent.com/19192104/72344533-4f2ba780-3686-11ea-8b65-f62d5b012d6a.png> Progress toward #14 <#14> ------------------------------ You can view, comment on, or merge this pull request online at: #726 Commit Summary - Change ship signatures based on system states File Changes - *M* src/spaceObjects/spaceship.cpp <https://github.com/daid/EmptyEpsilon/pull/726/files#diff-0> (14) - *M* src/spaceObjects/spaceship.h <https://github.com/daid/EmptyEpsilon/pull/726/files#diff-1> (2) Patch Links: - https://github.com/daid/EmptyEpsilon/pull/726.patch - https://github.com/daid/EmptyEpsilon/pull/726.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#726?email_source=notifications&email_token=ADJZY5OGRQ7WAQJW6LV2SNLQ5WVYTA5CNFSM4KGSGHF2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IGBHYNQ>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADJZY5MR7JV2BMSLPJ7OMD3Q5WVYTANCNFSM4KGSGHFQ> .

[daid]

Dont think it will effect performance at all. But it does break setting custom signatures from scripting i think.

[oznogon]

Ah, good point @daid — I'll revise.

[daid]

I also think this causes unneeded network traffic. As the signature is calculated on clients now as well as send to clients.

[oznogon]

If I understand correctly, it should be straightforward to move the loop into an if (game_server) condition to fix the network redundancy?

[daid]

Yes and no. It would remove the redundancy. But there is no reason to only calculate on the server and replicate it. Clients have all the info to calculate this.
Moving this calculation code to the function that gets the signature info would solve most things i think.
(On mobile. So a bit hard to lookup the specific code exactly)

[oznogon]

Updated the branch to move the logic to the RawScannerDataRadarOverlay component and changed the behavior on further testing.

• Coolant use can no longer result in negative bio band values.
• Jump drive grav spikes start small and grow larger closer to the jump.
• Jump drive recharge state causes an electrical spike that drops
  the closer the system gets to being fully recharged, and scales to the
  system's power level.
• A ship's electrical signature can be reduced by underpowering its systems.

The baseline radar signature is also slightly lower now to add some contrast between an idle and active ship.

[daid]

I was thinking this logic could also be moved to the "getRadarSignatureInfo" function, which could have been made virtual then and overloaded in the spaceship. However, that would mean the set and get functions would return different data, which is odd. So I've accepted this solution.