Probably fixes #17 issue and updated .gitignore #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added more ignores, Cura preferences are not needed in repo.
daid
added a commit
that referenced
this pull request
Apr 9, 2012
Probably fixes #17 issue and updated .gitignore
|
Also seems to work correctly for windows. But I think it will "leak" memory. As the SPPs are never released from memory, and cannot be garbage collected. Small price to pay for MacOS support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On OSX spp.Destroy() causes an segfault, sizer.Remove(app) removes app
from the form but tries to call spp.Destroy() afterwards.
By hiding and detaching I created a workaround for the OSX problem.
This solution needs testing on Windows and Linux.