Basic nack failed messages without requeue

daikon-cqrs · Aug 22, 2020 · c299663 · c299663
1 parent a3dc518
commit c299663
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/composer.lock b/composer.lock
diff --git a/src/Job/RabbitMq3Worker.php b/src/Job/RabbitMq3Worker.php
@@ -70,6 +70,7 @@ public function run(array $parameters = []): void
     private function execute(AMQPMessage $amqpMessage): void
     {
         $deliveryInfo = $amqpMessage->delivery_info;
+        /** @var AMQPChannel $channel */
         $channel = $deliveryInfo['channel'];
         $deliveryTag = $deliveryInfo['delivery_tag'];
 
@@ -84,6 +85,7 @@ private function execute(AMQPMessage $amqpMessage): void
 
         try {
             $this->messageBus->receive($envelope);
+            $channel->basic_ack($deliveryTag);
         } catch (RuntimeException $error) {
             /** @var JobDefinitionInterface $job */
             $job = $this->jobDefinitionMap->get($jobKey);
@@ -97,8 +99,7 @@ private function execute(AMQPMessage $amqpMessage): void
                 //@todo add message/metadata to error context
                 $this->logger->error($error->getMessage(), ['exception' => $error->getTrace()]);
             }
+            $channel->basic_nack($deliveryTag, false, false);
         }
-
-        $channel->basic_ack($deliveryTag);
     }
 }