Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Ability to "bookmark" lines #364

Closed
gloomytrousers opened this issue Apr 12, 2023 · 3 comments
Closed

[Feature request] Ability to "bookmark" lines #364

gloomytrousers opened this issue Apr 12, 2023 · 3 comments

Comments

@gloomytrousers
Copy link

Ability to "bookmark" lines - e.g. highlight them with a coloured mark next to the line number. Ability to toggle on/off in various ways:

  • via click on line number or keypress (e.g. Ctrl+F2 is common in other editors)
  • via Find - bookmark matching lines
  • invert all current bookmarks

As well as being useful visual cues, the bookmarks can be used for:

  • Navigation - jump to next and previous bookmark, via keypress (e.g. F2 and Shift+F2) or menu item
  • Replace only on bookmarked lines
@dail8859
Copy link
Owner

via Find - bookmark matching lines
Replace only on bookmarked lines

Though very possible these two will take some more time. The Find/Replace dialog is a bit of a pain to try to implement cleanly from a GUI perspective.

The other bullet points I have working and will push those changes hopefully today.

And just to be clear, you can already click on the bookmark margin and bookmark lines, but the other features are definitely very useful.

@gloomytrousers
Copy link
Author

Wow, thanks, that was quick!

@dail8859
Copy link
Owner

Closing for now since most of the features are implemented. The ones regarding find/replace functionality are definitely desireable but those will get rolled into a good revamp of the current Find/Replace dialog, since currently the code is a bit messy.

The commit adds several menu options:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants