-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sticky positioning demo #7
Conversation
<section> | ||
<h2>Header four</h2> | ||
<p> | ||
Jaguar shark! So tell me - does it really exist? Yeah, but John, if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lmfao
<h2>Enter a Daily room URL to join a Daily call</h2> | ||
<form id="joinForm"> | ||
<label for="url">Room URL</label> | ||
<input id="url" type="text" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we don't really want to do any validation here for simplicity, but could we just mark this field as required and make the type "url" to at least have the default checks that the URL is filled in and is at least a URL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Actually I cannot remember if I also mentioned this in the outline and you had a reason for not including that kind of validation here... sorry if I did and just forgot!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No reason other than to keep this supppper basic, but I can definitely update the input with those changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go for it! I think a couple of extra HTML attributes won't complicate it much and they'll provide significant benefit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one suggestion, and otherwise this lgtm!
hey @lazeratops little reminder for a final pr review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Daily Prebuilt demo that shows how the CSS
position:sticky;
property can be used to keep the call on screen even when the user scrolls down and the call would otherwise scroll off screen.Written in HTML/JS/CSS. Intentionally simple (didn't spend a ton of time on the CSS) because I don't want the actual focus (two lines of CSS!) to get lost in a sea of code.
As an addition to make it a little more interesting, the video call also shrinks on scroll so it takes up less space if the user is reading the content below the call.