Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(params): Add customisable committer params #377

Merged
merged 1 commit into from
Oct 11, 2023
Merged

feat(params): Add customisable committer params #377

merged 1 commit into from
Oct 11, 2023

Conversation

centrumek
Copy link
Contributor

@centrumek centrumek commented Oct 9, 2023 •
edited
Loading

Default Case:

Screenshot 2023-10-10 at 19 14 29 Screenshot 2023-10-10 at 19 15 00

Customised Case:

Screenshot 2023-10-10 at 18 49 37 Screenshot 2023-10-10 at 18 51 13

@centrumek centrumek force-pushed the feature/367/add-customisable-committer-params branch 23 times, most recently from 235aae5 to 0824ad2 Compare October 10, 2023 17:03
@centrumek centrumek marked this pull request as ready for review October 10, 2023 17:05
@centrumek centrumek mentioned this pull request Oct 10, 2023
Closed
@centrumek
Copy link
Contributor Author

Feature on behalf of #367

omBratteng
omBratteng requested changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@omBratteng omBratteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't commit the dist file, I'll build a new one when I release a new version.

omBratteng
omBratteng requested changes Oct 10, 2023
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
@centrumek centrumek force-pushed the feature/367/add-customisable-committer-params branch from 0824ad2 to 1887238 Compare October 10, 2023 17:12
@centrumek centrumek force-pushed the feature/367/add-customisable-committer-params branch 3 times, most recently from 125b775 to b6b4652 Compare October 10, 2023 17:20
@centrumek centrumek force-pushed the feature/367/add-customisable-committer-params branch from b6b4652 to 00f7f24 Compare October 10, 2023 17:21
@centrumek
Copy link
Contributor Author

@omBratteng, I've applied changes

@omBratteng omBratteng merged commit c16b74c into dailydotdev:main Oct 11, 2023
3 checks passed
omBratteng pushed a commit that referenced this pull request Oct 11, 2023
@centrumek @omBratteng
feat(params): Add customisable committer params (#377)
34fe3e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omBratteng omBratteng omBratteng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@centrumek @omBratteng