Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: always pass a string to className prop #2193

Merged
merged 2 commits into from Sep 19, 2023
Merged

fix: always pass a string to className prop #2193

merged 2 commits into from Sep 19, 2023

Conversation

DragosIorgulescu
Copy link
Contributor

Changes

self explanatory

Events

N / A

Manual Testing

On those affected packages:

  • Have you done sanity checks in the webapp?
  • Have you done sanity checks in the extension?
  • Does this not break anything in companion?

Did you test the modified components media queries?

  • MobileL (420px)
  • Tablet (656px)
  • Laptop (1020px)

Did you test on actual mobile devices?

  • iOS (Chrome and Safari)
  • Android

WT-1840 #done

@DragosIorgulescu DragosIorgulescu self-assigned this Sep 19, 2023
@DragosIorgulescu DragosIorgulescu requested a review from a team September 19, 2023 09:02
sshanzel
sshanzel approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@sshanzel sshanzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool fix.

rebelchris
rebelchris approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@rebelchris rebelchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting one!

@DragosIorgulescu DragosIorgulescu enabled auto-merge (squash) September 19, 2023 09:29
@DragosIorgulescu DragosIorgulescu merged commit 422a9c1 into WT-1778-move-to-react Sep 19, 2023
3 of 4 checks passed
@DragosIorgulescu DragosIorgulescu deleted the WT-1840-classname-boolean-error branch September 19, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebelchris rebelchris rebelchris approved these changes

@sshanzel sshanzel sshanzel approved these changes

Assignees

@DragosIorgulescu DragosIorgulescu

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@DragosIorgulescu @rebelchris @sshanzel